Is this ok for server performance?

I’m new to Minecraft datapacks, but I already know programming. Is there a better way to do this?
i'll post the code right after this msg