right click detection just not working

so im in 1.21.8 and i've followed a right click detection tutorial... it was working before and now it's not. these are the related functions and advancements:
dash.mcfunction:
advancement revoke @a only spleef_world:dash
say hi
effect give @a resistance 1 255 true
summon creeper ^ ^ ^-3 {NoAI:1b,Fuse:0,ignited:1b,Silent:1b}
givedash.mcfunction:
give @s feather[custom_name={"bold":false,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"Dash","underlined":false},custom_data={dash:true},consumable={consume_seconds:1000000,animation:"none",has_consume_particles:false},food={nutrition:0,saturation:0,can_always_eat:true}]
dash.json:
{
  "criteria": {
    "requirement": {
      "trigger": "minecraft:using_item",
      "conditions": {
        "item": {
          "items": "minecraft:feather",
          "components": {
            "minecraft:custom_data": {
              "dash:true": {}
            }
          }
        }
      }
    }
  },
  "rewards": {
    "function": "spleef_world:dash"
  }
}