Custom Crafter

I made a custom crafted I older version, more specifically this one: 
https://youtu.be/0Qm_YWSdUyE?si=cdxvTgXlts_4Jb9m
This method is efficient for the 1.21? Or there’s new method? bc I couldn’t find anything